Skip to content

Add HyperShift e2e gating tests to cluster-machine-approver#75309

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
bryan-cox:OCPBUGS-machine-approver-gating-tests
Feb 25, 2026
Merged

Add HyperShift e2e gating tests to cluster-machine-approver#75309
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
bryan-cox:OCPBUGS-machine-approver-gating-tests

Conversation

@bryan-cox
Copy link
Member

Summary

  • Add optional HyperShift AWS and AKS e2e presubmit tests to openshift/cluster-machine-approver CI configuration
  • Import hypershift-operator and hypershift-tests base images needed by the workflows

Motivation

cluster-machine-approver PR #286 introduced a TLS profile fetch (FetchAPIServerTLSProfile) that requires RBAC to read apiservers.config.openshift.io at cluster scope. This broke all HyperShift e2e tests using 4.22 CI nightlies built after the merge (2026-02-25T08:01Z). No HyperShift tests were gating the cluster-machine-approver repo, so the breakage wasn't caught before merge.

Changes

  • e2e-hypershift-aws: optional presubmit using hypershift-aws-e2e-external workflow
  • e2e-hypershift-aks: optional presubmit using hypershift-azure-aks-e2e workflow
  • Both triggered manually via /test e2e-hypershift-aws and /test e2e-hypershift-aks

Test plan

  • Verify CI config validation passes
  • Verify generated job configs are correct

🤖 Generated with Claude Code

@openshift-ci openshift-ci bot requested review from nrb and theobarberbany February 25, 2026 17:18
@bryan-cox bryan-cox force-pushed the OCPBUGS-machine-approver-gating-tests branch from 32ed1ab to 821bae6 Compare February 25, 2026 17:18
Add optional HyperShift AWS and AKS e2e presubmit tests to the
cluster-machine-approver CI configuration. This ensures that changes
to the machine-approver are validated against HyperShift environments
before merging.

Motivated by cluster-machine-approver PR openshift#286 which introduced a
TLS profile fetch requiring new RBAC that broke all HyperShift e2e
tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bryan-cox bryan-cox force-pushed the OCPBUGS-machine-approver-gating-tests branch from 821bae6 to 8dddeeb Compare February 25, 2026 17:27
@bryan-cox
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aks

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aws

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@bryan-cox
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aks

Let's try again. AKS was being really slow for me earlier locally on my machine.

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@damdo
Copy link
Member

damdo commented Feb 25, 2026

Thanks @bryan-cox

You'll need to add also add it to the release-4.22 and release-4.23 files, TY

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
… release-4.23

Extend HyperShift AWS and AKS e2e presubmit tests to the release-4.22
and release-4.23 branch configurations, matching the tests already added
to the main config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aks openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aws openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-hypershift-aks openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-hypershift-aws openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-release-4.23-e2e-hypershift-aks openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-release-4.23-e2e-hypershift-aws openshift/cluster-machine-approver presubmit Presubmit changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-aws openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-aws-capi-techpreview openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-aws-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-azure-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-gcp-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-e2e-upgrade openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-images openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-unit openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-release-4.22-verify-deps openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-aws openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-aws-capi-techpreview openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-aws-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-azure-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-gcp-operator openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-e2e-upgrade openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-images openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-okd-scos-e2e-aws-ovn openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-okd-scos-images openshift/cluster-machine-approver presubmit Ci-operator config changed
pull-ci-openshift-cluster-machine-approver-main-unit openshift/cluster-machine-approver presubmit Ci-operator config changed

A total of 35 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bryan-cox
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 25, 2026
@neisw
Copy link
Contributor

neisw commented Feb 25, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, damdo, neisw, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0f1747a into openshift:main Feb 25, 2026
15 checks passed
JianLi-RH added a commit to JianLi-RH/release that referenced this pull request Feb 26, 2026
JianLi-RH added a commit to JianLi-RH/release that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants